feat(ui): per-message banner to load remote images#30
Merged
Conversation
Detect remote http(s) URLs in `<img src>`, `<* background>`, `srcset`, `poster`, and CSS `url()`. When present, show an amber banner above the HTML preview iframe with a "Load images" button that widens the iframe CSP `img-src` directive to include `http: https:` for that message only. Other directives (scripts, fonts, frames, objects, forms) remain strict. State is local to MessageDetail and resets on message change, matching the pattern used by Gmail, Thunderbird, and Apple Mail. Closes #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http(s)references in HTML preview (<img src>,<* background>,srcset,poster, CSSurl()).img-srcdirective to${origin} data: http: https:for that message only. All other CSP directives stay strict (scripts, fonts, frames, objects, forms remain blocked).MessageDetailand resets on message change — switching away and back re-shows the banner. No localStorage, no global setting, no backend change.Closes #29.
Files
ui/src/components/MessageDetail.tsx—cspMeta(allowRemoteImages),hasRemoteImages(), banner + reactive memos inHtmlPreview..gitignore— ignore.playwright-mcp/(local browser test dumps).Test plan
<img src="https://...">→ banner shown, image blocked, CSP strict.img-src.<td background>,<img srcset>, CSSurl(http...),<video poster>.pnpm tsc --noEmitclean.pnpm exec prettier --checkclean.pnpm buildclean (60.4 KB JS / 32.9 KB CSS gzipped).cargo clippy --all-targets -- -D warningsclean.cargo test --workspacepasses.